Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterizing EBS Block device #34

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Parameterizing EBS Block device #34

merged 1 commit into from
Mar 21, 2018

Conversation

tfhartmann
Copy link
Member

This should help help address #31

@tfhartmann
Parameterizing EBS Block device
54a2a28 
This should help help address #31
@tfhartmann
Copy link
Member Author

@benorgil take a look at this and let me know what you think.

@tfhartmann tfhartmann requested a review from hakamadare March 16, 2018 18:50
red8888
red8888 approved these changes Mar 21, 2018
View reviewed changes
Copy link

@red8888 red8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks! I think this will work

@tfhartmann tfhartmann merged commit 9c91e91 into master Mar 21, 2018
@tfhartmann tfhartmann deleted the tfhartmann/adding_ebs_block_device_name branch March 21, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red8888 red8888 red8888 approved these changes

@hakamadare hakamadare Awaiting requested review from hakamadare

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tfhartmann @red8888