-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Mountpoint S3 CSI driver to EKS IRSA #459
feat: Add support for Mountpoint S3 CSI driver to EKS IRSA #459
Conversation
… name to match docs, coalescelist with defaults incl partion for defaults to support gov-cloud and other aws partitions, split bucket vs path permissions
Thanks a ton for the comments @bryantbiggs I think I have everything working and I also did validate with the working config I have before these updates (and temp move blocks for the resources that there were no plan changes) let me know if I need to change anything else. |
@antonbabenko - FYI, I had to add a hack into the pre-commit workflow since it looks like the Terraform bits are getting big and filling up disk. I wonder if this is related to the AWS SDK Go v1 to v2 migration - https://github.com/terraform-aws-modules/terraform-aws-iam/actions/runs/8126685348/job/22210719103?pr=459 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
## [5.36.0](v5.35.0...v5.36.0) (2024-03-03) ### Features * Add support for Mountpoint S3 CSI driver to EKS IRSA ([#459](#459)) ([21fb8d9](21fb8d9))
This PR is included in version 5.36.0 🎉 |
Thanks for finding the solution to this problem. I thought it was related to many runs of "terraform init", but it is very good to have more space and delete stuff (another way to get more space - k8sgpt-ai/k8sgpt#947 :) ). |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Adding the required policy for the S3 CSI driver
Motivation and Context
Fixes #456
Breaking Changes
No breaking changes - simply addition for the policy required for the S3 CSI
How Has This Been Tested?
pre-commit run -a
on my pull request