Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct typo credentials_arn -> credential_arn #36

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Correct typo credentials_arn -> credential_arn

Motivation and Context

Breaking Changes

  • No, it wasn't correct to begin with

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs requested a review from antonbabenko April 2, 2024 21:33
@antonbabenko antonbabenko merged commit b5bd6a4 into terraform-aws-modules:master Apr 3, 2024
6 checks passed
antonbabenko pushed a commit that referenced this pull request Apr 3, 2024
## [2.1.1](v2.1.0...v2.1.1) (2024-04-03)

### Bug Fixes

* Correct typo `credentials_arn` -> `credential_arn` ([#36](#36)) ([b5bd6a4](b5bd6a4))
@antonbabenko
Copy link
Member

This PR is included in version 2.1.1 🎉

@bryantbiggs bryantbiggs deleted the fix/cred-arn branch April 3, 2024 11:00
Copy link

github-actions bot commented May 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECR PullThroughCache implemented credentials_arn when the example documents credential_arn
2 participants