Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make load balancer optional #409

Closed
wants to merge 2 commits into from

Conversation

bmbferreira
Copy link

@bmbferreira bmbferreira commented Dec 20, 2024

Description

This makes the usage of a load balancer completely optional since it might not be needed to access atlantis.

Motivation and Context

Currently we are forcing the usage of a load balancer associated to the ecs service. That might not be needed since the access could be provided with something like cloudflare tunnels or AWS SSM sessions to make atlantis accessible from private networks without the need of a load balancer.

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

we already support using an external load balancer - lets start with an issue and reproduction before jumping into a PR

@bmbferreira bmbferreira changed the title make load balancer optional feat: make load balancer optional Dec 20, 2024
@bmbferreira
Copy link
Author

bmbferreira commented Dec 20, 2024

we already support using an external load balancer - lets start with an issue and reproduction before jumping into a PR

hey @bryantbiggs. Thanks but what I'm trying to implement is to actually skip the load balancer entirely. As I explain on the Motivation and Context the module forces me to have a load balancer (either external or created within the module) and I don't want to have a load balancer at all, that's why I'm setting the alb_target_group_arn and alb_security_group_id as 100% optional to be able to not have a load balancer. I can put that information on an issue first if you prefer and associate with this PR. I hope I'm making myself clear but please let me know and I can add more details.

@bmbferreira
Copy link
Author

either way, created an issue here as recommended @bryantbiggs: #410

again, hope it's clear enough. Thank you.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants