fix: FQDN detection when using an existing ALB (#379)

terraform-aws-modules · Dec 11, 2023 · 50ee855 · 50ee855
1 parent f983fd8
commit 50ee855
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/examples/github-separate/main.tf b/examples/github-separate/main.tf
@@ -67,6 +67,7 @@ module "atlantis" {
         valueFrom = try(module.secrets_manager["github-webhook-secret"].secret_arn, "")
       },
     ]
+    fqdn = module.alb.dns_name
   }
 
   service = {

diff --git a/main.tf b/main.tf
@@ -1,8 +1,7 @@
 locals {
   # Atlantis
   atlantis_url = "https://${try(coalesce(
-    try(var.atlantis.fqdn, null),
-    module.alb.route53_records["A"].fqdn,
+    try(var.atlantis.fqdn, module.alb.route53_records["A"].fqdn, null),
     module.alb.dns_name,
   ), "")}"
-Original file line number
+Diff line change
@@ Expand Up / @@ -67,6 +67,7 @@ module "atlantis" { @@
             valueFrom = try(module.secrets_manager["github-webhook-secret"].secret_arn, "")
           },
         ]
+        fqdn = module.alb.dns_name
       }
       service = {
@@ Expand Down @@