Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing 2 errors after null-safety #22

Merged
merged 3 commits into from
May 18, 2021

Conversation

dgilperez
Copy link
Contributor

Hi!

I am sending you 2 fixes in the same PR, sorry about that and let me know if you want me to split them:

  • After researching Discovery failed to start on _googlecast._tcp with error : 4 #21, I found that just retrying on that error will work. It is tested on my device successfully.
  • Some devices will have null values for certain keys on attr, so I made it a Map<String, Uint8List?>?. It is consistent with dart_chromecast changes we also sent upstream.

Let me know what do you think

@dgilperez dgilperez changed the title Fixing Fixing 2 errors after null-safety Apr 20, 2021
@terrabythia terrabythia merged commit 894080a into terrabythia:master May 18, 2021
@terrabythia
Copy link
Owner

Thank you!

@dgilperez
Copy link
Contributor Author

Great stuff! Can you please release a new version to pub.dev?

@Ahmadre
Copy link

Ahmadre commented May 29, 2021

@terrabythia if you don't have time to maintain your package, please add some contributors :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants