Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated NerdFonts to v3.0.2 #212

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Conversation

TomJo2000
Copy link
Member

As of v3.0.0 NerdFonts has dropped a set of erroneous glyphs in the range U+F500 - U+FD46.
Which was previously overlapping with the Unicode ranges dedicated for:

  • CJK Compatibility Ideographs
  • Alphabetic Presentation Forms and
  • Arabic Presentation Forms-A

For further details see the upstream issue and v3.0.0 release.

Additionally the 3.x.x release of NerdFonts introduced breaking changes to the naming conventions of the provided patched fonts.
As such I have updated the script with the new names and subdirectories of the fonts.
I have also taken this opportunity to reformat the script in a more concise, easier to maintain and extend, fashion.

@agnostic-apollo
Copy link
Member

agnostic-apollo commented Jul 29, 2023

Thanks. Looks better. Should probably add a log entry at start and at end for success.

@TomJo2000
Copy link
Member Author

Thanks. Looks better. Should probably add a log entry at start and at end for success.

I'll add one, got something specific in mind?

- Addresses Unicode Range collisions.
- Made script easier to extend/maintain.
- Added additional log messages

Signed-off-by: TomIO <[email protected]>
@TomJo2000 TomJo2000 marked this pull request as ready for review July 29, 2023 22:34
@TomJo2000
Copy link
Member Author

Updated the script with new starting and ending log messages.
I also added a running count.
image

image

@fornwall
Copy link
Member

fornwall commented Oct 8, 2023

Thanks - this will be included in version 0.31!

@fornwall fornwall merged commit 105ef50 into termux:master Oct 8, 2023
@TomJo2000
Copy link
Member Author

Oh I almost forgot about this PR.
Thanks.

@TomJo2000 TomJo2000 deleted the update-nerd-fonts branch October 8, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants