Skip to content
This repository was archived by the owner on Feb 16, 2018. It is now read-only.

Fix issue #3 where key expiry is incorrectly propagated to keys without expiry #4

Merged
merged 1 commit into from
Dec 7, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions decoder.go
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ func (d *decode) decode() error {
if err != nil {
return err
}
expiry = 0
}
}

Expand Down
9 changes: 9 additions & 0 deletions decoder_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,15 @@ func (s *DecoderSuite) TestExpiry(c *C) {
c.Assert(r.expiries[0]["expires_ms_precision"], Equals, int64(1671963072573))
}

func (s *DecoderSuite) TestMixedExpiry(c *C) {
r := decodeRDB("keys_with_mixed_expiry")
c.Assert(r.expiries[0]["key01"], Not(Equals), int64(0))
c.Assert(r.expiries[0]["key04"], Not(Equals), int64(0))

c.Assert(r.expiries[0]["key02"], Equals, int64(0))
c.Assert(r.expiries[0]["key03"], Equals, int64(0))
}

func (s *DecoderSuite) TestIntegerKeys(c *C) {
r := decodeRDB("integer_keys")
c.Assert(r.dbs[0]["125"], Equals, "Positive 8 bit integer")
Expand Down
Binary file added fixtures/keys_with_mixed_expiry.rdb
Binary file not shown.