Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce prod porting #2532

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Reduce prod porting #2532

wants to merge 18 commits into from

Commits on Mar 28, 2024

  1. implement float reduce prod. Need to implement quantized version. Use… 

    … SumorMean Quantixzed function for now
    @Evanok
    Evanok committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    38b4456 View commit details
    Browse the repository at this point in the history

  2. lets try to add some test for the reduce prod float version for now

    @Evanok
    Evanok committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    ad2b039 View commit details
    Browse the repository at this point in the history

  3. instead of reimplementing reduce prod quantized used the dead functio… 

    …n already present there
    @Evanok
    Evanok committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7ad0aea View commit details
    Browse the repository at this point in the history

  4. fix compilation. Need to use the RuntimeShape time to send dimension

    @Evanok
    Evanok committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    4de30dc View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. add more test for prod reduce

    @Evanok
    Evanok committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    b365436 View commit details
    Browse the repository at this point in the history

  2. add more test for prod reduce

    @Evanok
    Evanok committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    865cc79 View commit details
    Browse the repository at this point in the history

  3. add ReduceProd function based on the ReduceMeanOrSum function code

    @Evanok
    Evanok committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    f94d5aa View commit details
    Browse the repository at this point in the history

  4. aligned on main branch

    @Evanok
    Evanok committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    457edde View commit details
    Browse the repository at this point in the history

  5. restore original layout

    @Evanok
    Evanok committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    0d5e153 View commit details
    Browse the repository at this point in the history

  6. Restore new line

    @Evanok
    Evanok committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    c2f4d8a View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. let's use the QuantizedReduceProd implementation instead of my own im… 

    …plementation. Fixed the way to initialize the RuntimeShape
    @Evanok
    Evanok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    9618bb1 View commit details
    Browse the repository at this point in the history

  2. add the problematic test in the porting branch

    @Evanok
    Evanok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    976aa82 View commit details
    Browse the repository at this point in the history

  3. Add new PROD test based on SUM test

    @Evanok
    Evanok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    aec08ff View commit details
    Browse the repository at this point in the history

  4. remove my QuantizedReduceProd implem. Used the function already prese… 

    …nt into the repo
    @Evanok
    Evanok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    3c91b2f View commit details
    Browse the repository at this point in the history

  5. Update PrepareProdHelper implementation based on lite version

    @Evanok
    Evanok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    a3dc465 View commit details
    Browse the repository at this point in the history

  6. remove redundant test

    @Evanok
    Evanok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    048c534 View commit details
    Browse the repository at this point in the history

  7. all float test on reduce prod seems to work fine now

    @Evanok
    Evanok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    cc369a8 View commit details
    Browse the repository at this point in the history

  8. Use same way to write value for all test

    @Evanok
    Evanok committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    480479d View commit details
    Browse the repository at this point in the history