MDCMigration: Restyle all plugins selector component for MDC migration. #6612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
force-pushed
the
mdc-migration-plugin-component-attempt-2
branch
from
4012cae to
663297e
Compare
JamesHollyer
approved these changes
Oct 3, 2023
| @@ -36,12 +37,13 @@ | |||
| </mat-tab-group> | |||
| <mat-form-field | |||
| floatLabel="never" | |||
| *ngIf="disabledPlugins.length" | |||
| *ngIf="disabledPlugins.length > 0" | |||
There was a problem hiding this comment.
I think just checking length is sufficient.
There was a problem hiding this comment.
Probably but this is the code that was there before we made the branch so I prefer not to change it.
| right: 0; | ||
| } | ||
|
|
||
| .mat-mdc-tab-header-pagination { |
There was a problem hiding this comment.
The color of the pagination carrot is black in light mode which looks strange. I think it should stay the same color in both light and dark mode just like the plugin name text.
| class="active-plugin-list" | ||
| [selectedIndex]="getActivePluginIndex()" | ||
| animationDuration="100ms" | ||
| > | ||
| <mat-tab *ngFor="let plugin of activePlugins"> | ||
| <mat-tab *ngFor="let plugin of activePlugins" [disabled]="!plugin.enabled"> |
There was a problem hiding this comment.
We had some weird bugs around this disabled property before. However, this seems to all be working great.
There was a problem hiding this comment.
I just kept the code that was originally there before we made the branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at restyling the plugins selector component for MDC Migration.
We start by reverting the previous attempt so that we have a good base for the conversion.
(See b846aae)
We then take the approach of attempting to adjust the current styling to mdc components as much as possible, in order to preserve current styling and current behavior.
(See 4012cae for the clean diff compared to original)
The end result is:
Some sample screenshots but please patch it locally to play with it: