Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding Projector: Move Supervise with parameters to t-SNE #6290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alicialics
Copy link
Contributor

@alicialics alicialics commented Apr 5, 2023

Motivation for features / changes

Supervise with parameters are only applicable to t-SNE projection. This moves it from data panel to projections panel, and simplifying code in the process (no longer needed to notify projection changes to the data panel)

Technical description of changes

Move Supervise by to the t-SNE panel

Screenshots of UI changes

Before:
image
After:
image

Detailed steps to verify changes work correctly (as executed by you)

verify Supervise By works

Alternate designs / implementations considered

initialize input

fix lint

bookmark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants