Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shareability: re-arrange metrics state order #6224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

japie1235813
Copy link
Contributor

  • Motivation for features / changes
    Re-arrange metrics state order to make it clear those states might affect what aspect.

@japie1235813 japie1235813 requested a review from bmd3k March 8, 2023 14:13
@@ -161,14 +161,13 @@ export type CardToPinnedCard = Map<NonPinnedCardId, PinnedCardId>;
export type PinnedCardToCard = Map<PinnedCardId, NonPinnedCardId>;

export interface MetricsNamespacedState {
/*
* Date-related states: states below are drived from the server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Date => Data.
drived => derived.

cardToPinnedCopy: CardToPinnedCard;
// A map of card ids that previously pinned by the user.
cardToPinnedCopyCache: CardToPinnedCard;
pinnedCardToOriginal: PinnedCardToCard;
cardStateMap: CardStateMap;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cardStateMap has both data-related (dataMinMax) and ui-related states (everything else).

Might be worth separating it out into a third category here and then similarly organizing it to clearly separate data-related and ui-related states.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants