This repository was archived by the owner on Apr 23, 2025. It is now read-only.
Add tensorflow/swift-apis as a SwiftPM dependency. #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables building tensorflow/swift-models using stock toolchains from swift.org/download.
compnerd
approved these changes
Jan 10, 2021
| .target(name: "ImageClassificationModels", path: "Models/ImageClassification"), | ||
| .target(name: "VideoClassificationModels", path: "Models/Spatiotemporal"), | ||
| .target(name: "TextModels", | ||
| name: "ModelSupport", dependencies: ["TensorFlow", "STBImage"], path: "Support", |
There was a problem hiding this comment.
While doing this, it might be nice to format this as:
.target(
name: "ModelSupport",
dependencies: [
"TensorFlow",
"STBImage",
],
path: "Support"),and similarly throughout. It makes it easier to read at a glance due to the one-item per line. It also makes future changes trivial to read.
|
I can confirm the same run failure locally: swift-linear-regression % swift run -Xswiftc -DTENSORFLOW_USE_STANDARD_TOOLCHAIN -Xcc -I/Library/tensorflow-2.4.0/usr/include -Xlinker -L/Library/tensorflow-2.4.0/usr/lib
dyld: Library not loaded: @rpath/libx10.dylib
Referenced from: /Users/Alexey_Novakov/dev/git/swift-linear-regression/.build/x86_64-apple-macosx/debug/libTensorFlow.dylib
Reason: image not found
zsh: abort swift run -Xswiftc -DTENSORFLOW_USE_STANDARD_TOOLCHAIN -Xcc -Xlinker |
That may be a different failure. _Differentiation should now load. You could try copying the libx10.dylib binary into the Swift build products folder after compiling. In addition, it should not be necessary to pass libx10 into the linker settings for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This enables building
tensorflow/swift-modelsusing stock toolchains from swift.org/download.swift buildwill clone and buildtensorflow/swift-apisas a regular SwiftPM dependency. Eventually, we would like to stop releasing custom toolchains bundled with pre-installedtensorflow/swift-apis.Build instructions
It is possible to build
tensorflow/swift-apisand dependencies liketensorflow/swift-modelsusing stock toolchains by installing pre-built X10 libraries (currently available only for macOS and Windows).After installing (e.g. to
$HOME/Libraryon macOS), build with SwiftPM via the following:$ swift build -Xcc -I$HOME/Library/tensorflow-2.4.0/usr/include -Xlinker -L$HOME/Library/tensorflow-2.4.0/usr/lib -Xswiftc -DTENSORFLOW_USE_STANDARD_TOOLCHAINswift testis known not to work on macOS fortensorflow/swift-apisand dependencies due to SR-14008:Library not loaded: /usr/lib/swift/libswift_Differentiation.dylib.Testing
Before merging, let's verify that
swift build,swift run, andswift testworks for swift.org/download toolchains across platforms:swift runandswift testcurrently both fail due to SR-14008: