-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArcFace Loss Implementation #291
base: development
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thanks for the PR. Looks like there are duplicate files again for the loss and the tests, and I think you'll need to run the Black and Isort formatting (the imports in the init.py look out of order again). Also let me know your thoughts regarding adding the sub-centers layer. I think the weights that map the embedding to the N classes (and optionally the K sub-centers) needs to be a Dense layer so that we can train the weights. The current implementation has the matrix as a variable in loss so I don't think the random values will be updated during training. |
The function should be tf.concat instead of tf.constant, according to the description given above. This also resolves issue tensorflow#284
Initial review of notebook. Removed empty cells and verified that everything WAI.
Ps. Previous Pull Request Deleted, due to the conflict of commits