fix: migrating from contrib to keras regularizer #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rishav1
force-pushed
the
fix_mnist_lr_example
branch
from
9104a53 to
f0cbcbb
Compare
Rishav1
commented
Jul 23, 2020
| @@ -169,14 +165,17 @@ def print_privacy_guarantees(epochs, batch_size, samples, noise_multiplier): | |||
| np.linspace(20, 100, num=81)]) | |||
| delta = 1e-5 | |||
| for p in (.5, .9, .99): | |||
| steps = math.ceil(steps_per_epoch * p) # Steps in the last epoch. | |||
| coef = 2 * (noise_multiplier * batch_size)**-2 * ( | |||
There was a problem hiding this comment.
Not sure if first term in coef is correct here:
- The Lipshitz constant (using data_l2_norm) is missing.
- Why is batch_size here? If the RDP of Subsampled Gaussian Mechanism result from table 1 of this work is being used, shouldn't
q = batch_size / steps_per_epochinstead ofq = 1 / batch_size?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example was outdated. Fixed to use keras L2 regularizer.