Add fp16 option for NNAPI in Android classification example #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you link to a screenshot of the new UI? Thanks. |
|
|
jdduke
reviewed
Oct 24, 2019
| @@ -34,7 +34,7 @@ | |||
| */ | |||
| public ClassifierQuantizedMobileNet(Activity activity, Device device, int numThreads) | |||
| throws IOException { | |||
| super(activity, device, numThreads); | |||
| super(activity, device, numThreads, false); | |||
jdduke
requested changes
Oct 24, 2019
|
Thanks for the review. I don't know how difficult it is. I'll try to disable or gray out the switch. I am not familiar with Android widgets. |
freedomtan
force-pushed
the
add_fp16_to_classification
branch
from
a3588ae to
48aa506
Compare
|
rebased to resolve conflict |
jdduke
previously approved these changes
Nov 20, 2019
Some NNAPI accelerators are fp16 only. Add an option to allow fp32 on fp16 accelerators.
enable the FP16 switch only when NNAPI and floating point model are used.
freedomtan
force-pushed
the
add_fp16_to_classification
branch
from
48aa506 to
33aa4c3
Compare
|
rebased and resovled conflicts |
jdduke
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some NNAPI accelerators are fp16 only. Add an option to allow fp32 on fp16 accelerators.