File sync for envd-server #1352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AlexXi19 <[email protected]>
Signed-off-by: AlexXi19 <[email protected]>
Signed-off-by: AlexXi19 <[email protected]>
Signed-off-by: AlexXi19 <[email protected]>
Signed-off-by: AlexXi19 <[email protected]>
Signed-off-by: AlexXi19 <[email protected]>
Signed-off-by: AlexXi19 <[email protected]>
Signed-off-by: AlexXi19 <[email protected]>
Signed-off-by: AlexXi19 <[email protected]>
VoVAllen
reviewed
Dec 29, 2022
| ) | ||
|
|
||
| // Makes API calls to the syncthing instance | ||
| func (s *Syncthing) ApiCall(method string, url string, params map[string]string, body []byte) ([]byte, error) { |
There was a problem hiding this comment.
Is this code borrowed from other repo? Please keep license head if so.
There was a problem hiding this comment.
Also the client style is not consistent with our current HTTP client
There was a problem hiding this comment.
Ok, yeah this is borrowed for now, I was going to ask you about the http client after you wake up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft pull request for tensorchord/envd-server#102