Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added searchExpressions and Group joins support #3

Merged
merged 2 commits into from
May 8, 2018

Conversation

andreysmyntyna
Copy link

@andreysmyntyna andreysmyntyna commented Jan 18, 2018

Which issue this PR fixes

Adds ability of grouping joined fields and utilizing filter expressions (OR\AND operators). Options are switched off by default.

Special notes for your reviewer:
required by netsuite-crm-integration
Original code for grouping has been taken from acumenbrands#31
and simplified a bit

Could be used like this

        const query = {
            record_type: recordType,
            batch_size: 5000,
            lower_bound: -9999,
            search_filters: searchFilters,
            search_columns: searchColumns,
            **advanced_options: {
                useFilterExpressions: true,
                groupJoins: true
            })**
        };

@andreysmyntyna andreysmyntyna merged commit 2bf700d into master May 8, 2018
@andreysmyntyna andreysmyntyna deleted the feature/group-join-filter-expression branch May 8, 2018 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants