Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inititial Commit of SentinelOne Connector #19

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

SteveMcGrath
Copy link
Contributor

Description

Initial version of the SentinelOne -> Tenable One Connector

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Full compliment of unit tests
  • Manual testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SteveMcGrath SteveMcGrath requested a review from a team as a code owner January 8, 2025 15:11
Copy link

github-actions bot commented Jan 8, 2025

🔍 Vulnerabilities of connector-sentinelone2tone:latest

📦 Image Reference connector-sentinelone2tone:latest
digestsha256:1f71fd41fe53cf5aca69f2c734af915712450d11f3c2e86c674458c147a5d1d0
vulnerabilitiescritical: 0 high: 0 medium: 0 low: 0
platformlinux/amd64
size85 MB
packages102
📦 Base Image python:3.12-alpine
also known as
  • 3.12-alpine3.21
  • 3.12.8-alpine
  • 3.12.8-alpine3.21
digestsha256:dbf048474ebc26a73f8d359e4a60cd59af7e76bc7f8351bce0f4a85eaa71d393
vulnerabilitiescritical: 0 high: 0 medium: 0 low: 0

Copy link

github-actions bot commented Jan 8, 2025

Recommended fixes for image connector-sentinelone2tone:latest

Base image is python:3.12-alpine

Name3.12.8-alpine3.21
Digestsha256:dbf048474ebc26a73f8d359e4a60cd59af7e76bc7f8351bce0f4a85eaa71d393
Vulnerabilitiescritical: 0 high: 0 medium: 0 low: 0
Pushed1 month ago
Size18 MB
Packages56
Flavoralpine
OS3.21
Runtime3.12.8
The base image is also available under the supported tag(s): 3.12-alpine3.21, 3.12.8-alpine, 3.12.8-alpine3.21

Refresh base image

Rebuild the image using a newer base image version. Updating this may result in breaking changes.

✅ This image version is up to date.

Change base image

TagDetailsPushedVulnerabilities
3.13-alpine
Tag is preferred tag
Also known as:
  • alpine
  • alpine3.21
  • 3.13.1-alpine
  • 3.13.1-alpine3.21
  • 3.13-alpine3.21
  • 3-alpine
  • 3-alpine3.21
Benefits:
  • Same OS detected
  • Minor runtime version update
  • Image is smaller by 1.1 MB
  • Image contains 13 fewer packages
  • Tag is preferred tag
  • Image has same number of vulnerabilities
Image details:
  • Size: 17 MB
  • Flavor: alpine
  • OS: 3.21
  • Runtime: 3.13.1
1 month ago



@rk-tenb
Copy link

rk-tenb commented Jan 8, 2025

________________________________________________________________ ERROR collecting tests/test_transform.py _________________________________________________________________ ImportError while importing test module '/Users/rkendall/tenable-connectors/connectors/sentinelone2tone/tests/test_transform.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: /opt/homebrew/Cellar/[email protected]/3.11.10/Frameworks/Python.framework/Versions/3.11/lib/python3.11/importlib/__init__.py:126: in import_module return _bootstrap._gcd_import(name[level:], package, level) tests/test_transform.py:5: in <module> from tenable.io.sync.models.device_asset import DeviceAsset E ModuleNotFoundError: No module named 'tenable.io.sync' ========================================================================= short test summary info ========================================================================= ERROR tests/test_transform.py

Copy link

@rk-tenb rk-tenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once changes made, looks fine to me if tests built

connectors/sentinelone2tone/connector.py Outdated Show resolved Hide resolved
connectors/sentinelone2tone/cli.py Outdated Show resolved Hide resolved
connectors/sentinelone2tone/pyproject.toml Show resolved Hide resolved
@SteveMcGrath SteveMcGrath force-pushed the feature/sentinelone2tone branch from a739eeb to ef883e8 Compare January 8, 2025 17:29
@SteveMcGrath SteveMcGrath merged commit 9f95fc7 into main Jan 8, 2025
7 checks passed
@SteveMcGrath SteveMcGrath deleted the feature/sentinelone2tone branch January 8, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants