Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Workflow to read from the head instead as checking against main on merge will always result in nothing #18

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

SteveMcGrath
Copy link
Contributor

@SteveMcGrath SteveMcGrath commented Jan 7, 2025

Description

Updated Deployment pipeline connector matrix creation in order to correct for how the matrix is computed. The previous
approach works on PRs as the comparison is against main. However the deployment pipeline must compare against the
prior commit in the HEAD as the PR changes have already been merged in.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested locally with act

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SteveMcGrath SteveMcGrath requested a review from a team as a code owner January 7, 2025 18:39
@SteveMcGrath SteveMcGrath merged commit e6d8d39 into main Jan 7, 2025
5 checks passed
@SteveMcGrath SteveMcGrath deleted the chore/deploy-fix-merge-matrix branch January 7, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants