-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added voi explorer links #49
Conversation
Id: <Link to={`/token/${token.appId}`}>{token.appId}</Link> | ||
Id:{" "} | ||
<a | ||
href={`https://voi.observer/explorer/application/${token.appId}/transactions/`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have this link be return by a function that takes node, appId. You may leave the link for 'algorand' and 'algorand-testnet' not yet implemented.
Also, use target _blank and rel nofollow,noreferrer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there will be two functions. One for the appId and one for address?
{NFDService.getNFDByAddress(address)?.[address]?.name} | ||
</a> | ||
) : ( | ||
<a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above here
Should also fix token id link on this page
|
I'll work on the changes and will notify you once they are ready for review. |
Issue #47