Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-2502 - handle WorkflowExecutionUpdateAdmitted events #2364

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rossedfort
Copy link
Contributor

Description & motivation 💭

this event type is only used on post-reset workflows when updates are reapplied, but we still want to show their attributes in the event history

Screenshots (if applicable) 📸

before after
Screenshot 2024-10-02 at 10 50 59 AM Screenshot 2024-10-02 at 12 01 18 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

this event type is only used on post-reset workflows when updates are reapplied,
but we still want to show their attributes in the event history
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:36pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants