Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Execution Page - Bring into the Light #2269

Merged
merged 52 commits into from
Aug 27, 2024
Merged

Conversation

Alex-Tideman
Copy link
Contributor

@Alex-Tideman Alex-Tideman commented Aug 14, 2024

Description & motivation 💭

Remove Labs Mode and have a single Workflow Execution Page experience for all.

The theme of this PR is "Show Everything". Don't hide any information or abilities behind an option or setting. Give the user all the information at once. For example, show all the Event Type filters and show timestamp plus the elapsed time. Show the Timeline always for visual reference. Show all related events at once when you open a row, don't hide each one behind a click. Show all the event attributes at once, don't hide them behind a Pill.

Changes:

  • Always show Timeline view
  • Float start/end timestamps on Timeline Axis
  • Remove Compact View visual
  • Add Graph visual to the Event History Table (only for All events, not for Compact)
  • Show filters always
  • Add Pending/Failed only event filter
  • Desc/Asc with polling
  • Pause button to not update UI if heavy polling is happening
  • Table rows are more dense,
  • Add Pending Activities and Pending Nexus Operations as rows with Attempt count
  • Include multiple attributes on a single row in the table for more context.
  • Include all related events when row is expanded.
  • Make all visuals Day/Night mode.

Screenshots (if applicable) 📸

Screenshot 2024-08-26 at 1 05 18 PM Screenshot 2024-08-26 at 1 06 15 PM Screenshot 2024-08-26 at 1 06 47 PM Screenshot 2024-08-26 at 1 07 14 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 5:05pm

@Alex-Tideman Alex-Tideman changed the title Workflow page v2 Workflow Execution Page - Bring into the Light Aug 26, 2024
@Alex-Tideman Alex-Tideman marked this pull request as ready for review August 26, 2024 18:12
@trin4ik
Copy link

trin4ik commented Aug 28, 2024

looks great, ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants