Remove unnecessary button props (#2089)

* Remove unused icon prop in Button * Remove unused round prop in MenuButton * Remove unnecessary Button story
temporalio · May 6, 2024 · 9442a18 · 9442a18
1 parent 2b8b941
commit 9442a18
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 37 deletions.
diff --git a/src/lib/holocene/button.stories.svelte b/src/lib/holocene/button.stories.svelte
@@ -33,14 +33,6 @@
         name: 'Count',
         control: { type: 'number', min: 0, max: 99, step: 1 },
       },
-      icon: {
-        name: 'Icon',
-        control: 'select',
-        options: iconNames,
-        table: {
-          category: 'Icon',
-        },
-      },
       leadingIcon: {
         name: 'Leading Icon',
         control: 'select',
@@ -143,8 +135,6 @@
 
 <Story name="With Count" args={{ count: 5 }} />
 
-<Story name="With Icon" args={{ icon: 'workflow' }} />
-
 <Story name="With Leading Icon" args={{ leadingIcon: 'workflow' }} />
 
 <Story name="With Trailing Icon" args={{ trailingIcon: 'workflow' }} />
@@ -262,16 +252,6 @@
   }}
 />
 
-<Story
-  name="With Icon (Dark)"
-  args={{ icon: 'workflow' }}
-  parameters={{
-    themes: {
-      themeOverride: 'dark',
-    },
-  }}
-/>
-
 <Story
   name="With Leading Icon (Dark)"
   args={{ leadingIcon: 'workflow' }}

diff --git a/src/lib/holocene/button.svelte b/src/lib/holocene/button.svelte
@@ -71,7 +71,6 @@
   );
 
   type BaseProps = {
-    icon?: IconName;
     disabled?: boolean;
     loading?: boolean;
     leadingIcon?: IconName;
@@ -103,7 +102,6 @@
   export let trailingIcon: IconName = null;
   export let count = 0;
   export let id: string = null;
-  export let icon: IconName = null;
   export let href: string = null;
   export let target: string = null;
   export let active = false;
@@ -128,14 +126,11 @@
     type="button"
     target={target ? '_blank' : null}
     rel={target ? 'noreferrer' : null}
-    class={merge(
-      icon ? 'inline-flex' : 'inline',
-      buttonStyles({
-        variant,
-        size,
-        borderRadiusModifier,
-      }),
-    )}
+    class={buttonStyles({
+      variant,
+      size,
+      borderRadiusModifier,
+    })}
     on:click={onLinkClick}
     tabindex={href ? null : 0}
     {...$$restProps}

diff --git a/src/lib/holocene/menu/menu-button.svelte b/src/lib/holocene/menu/menu-button.svelte
@@ -31,7 +31,6 @@
     variant?: MenuButtonVariant;
     class?: string;
     active?: boolean;
-    round?: boolean;
     'data-testid'?: string;
   }
 
@@ -44,7 +43,6 @@
   export let id: string = null;
   export let label: string = null;
   export let variant: MenuButtonVariant = 'secondary';
-  export let round = false;
 
   const dispatch = createEventDispatcher<{ click: { open: boolean } }>();
   const { open, menuElement } = getContext<MenuContext>(MENU_CONTEXT);
@@ -105,11 +103,7 @@
   {...$$restProps}
 >
   <slot name="leading" />
-  <div
-    class="flex grow items-center"
-    class:justify-center={round}
-    class:hidden={!$$slots.default}
-  >
+  <div class="flex grow items-center" class:hidden={!$$slots.default}>
     <slot />
   </div>
   {#if hasIndicator}