Skip to content

Commit

Permalink
Small UI fixes (#2248)
Browse files Browse the repository at this point in the history
* Don't show error when menu is open in Combobox

* Remove unnecessary surface-information class
  • Loading branch information
laurakwhit authored Aug 1, 2024
1 parent e9b014e commit 6cb9798
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
7 changes: 4 additions & 3 deletions src/lib/holocene/combobox/combobox.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -305,9 +305,6 @@
</div>
{/if}
</div>
{#if error && !valid}
<span class="error">{error}</span>
{/if}

<Menu bind:menuElement id="{id}-listbox" role="listbox" class="w-full">
{#each list as option}
Expand All @@ -334,6 +331,10 @@
<ComboboxOption disabled>{noResultsText}</ComboboxOption>
{/each}
</Menu>

{#if error && !valid}
<span class="error">{error}</span>
{/if}
</MenuContainer>

<style lang="postcss">
Expand Down
4 changes: 2 additions & 2 deletions src/lib/holocene/input/range-input.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
id="{id}-range"
name="range"
type="range"
class="surface-information h-0 w-full cursor-pointer appearance-none rounded border-y border-primary"
class="h-0 w-full cursor-pointer appearance-none rounded border-y border-primary"
bind:value
on:input={handleInput}
{min}
Expand Down Expand Up @@ -148,7 +148,7 @@
}
input[type='range']::-webkit-slider-thumb {
@apply surface-information h-4 w-8 appearance-none rounded-full border-2 border-solid border-primary;
@apply h-4 w-8 appearance-none rounded-full border-2 border-solid border-primary bg-information;
}
input[type='range']::-moz-range-thumb {
Expand Down
3 changes: 0 additions & 3 deletions src/lib/theme/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,6 @@ const temporal = plugin(
backgroundColor: css('--color-interactive-ghost-active'),
},
},
'.surface-information': {
backgroundColor: css('--color-surface-information'),
},
'.surface-inverse': {
backgroundColor: css('--color-surface-inverse'),
color: css('--color-text-inverse'),
Expand Down

0 comments on commit 6cb9798

Please sign in to comment.