Remove encodingDecoded field (#2274)

temporalio · Aug 23, 2024 · 32d26b1 · 32d26b1
1 parent 61ab2bf
commit 32d26b1
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 25 deletions.
diff --git a/src/fixtures/local-activities/dotnet_local_activity.json b/src/fixtures/local-activities/dotnet_local_activity.json
@@ -22,8 +22,7 @@
         "payloads": [
           {
             "metadata": {
-              "encoding": "anNvbi9wbGFpbg==",
-              "encodingDecoded": "json/plain"
+              "encoding": "anNvbi9wbGFpbg=="
             },
             "data": "some-static-value"
           }

diff --git a/src/fixtures/local-activities/go_local_activity.json b/src/fixtures/local-activities/go_local_activity.json
@@ -22,8 +22,7 @@
         "payloads": [
           {
             "metadata": {
-              "encoding": "anNvbi9wbGFpbg==",
-              "encodingDecoded": "json/plain"
+              "encoding": "anNvbi9wbGFpbg=="
             },
             "data": "Hello Temporal!"
           }

diff --git a/src/fixtures/local-activities/java_local_activity.json b/src/fixtures/local-activities/java_local_activity.json
@@ -12,8 +12,7 @@
         "payloads": [
           {
             "metadata": {
-              "encoding": "anNvbi9wbGFpbg==",
-              "encodingDecoded": "json/plain"
+              "encoding": "anNvbi9wbGFpbg=="
             },
             "data": "9376db60-4eb5-3525-8f39-e61024fab1d1"
           }
@@ -23,15 +22,13 @@
         "payloads": [
           {
             "metadata": {
-              "encoding": "anNvbi9wbGFpbg==",
-              "encodingDecoded": "json/plain"
+              "encoding": "anNvbi9wbGFpbg=="
             },
             "data": "Hello"
           },
           {
             "metadata": {
-              "encoding": "anNvbi9wbGFpbg==",
-              "encodingDecoded": "json/plain"
+              "encoding": "anNvbi9wbGFpbg=="
             },
             "data": "World"
           }
@@ -41,8 +38,7 @@
         "payloads": [
           {
             "metadata": {
-              "encoding": "anNvbi9wbGFpbg==",
-              "encodingDecoded": "json/plain"
+              "encoding": "anNvbi9wbGFpbg=="
             },
             "data": {
               "firstSkd": 1705398005183,
@@ -56,8 +52,7 @@
         "payloads": [
           {
             "metadata": {
-              "encoding": "anNvbi9wbGFpbg==",
-              "encodingDecoded": "json/plain"
+              "encoding": "anNvbi9wbGFpbg=="
             },
             "data": "Hello World!"
           }
@@ -67,8 +62,7 @@
         "payloads": [
           {
             "metadata": {
-              "encoding": "anNvbi9wbGFpbg==",
-              "encodingDecoded": "json/plain"
+              "encoding": "anNvbi9wbGFpbg=="
             },
             "data": 1705398005129
           }

diff --git a/src/fixtures/local-activities/python_local_activity.json b/src/fixtures/local-activities/python_local_activity.json
@@ -22,8 +22,7 @@
         "payloads": [
           {
             "metadata": {
-              "encoding": "anNvbi9wbGFpbg==",
-              "encodingDecoded": "json/plain"
+              "encoding": "anNvbi9wbGFpbg=="
             },
             "data": "Hello, World!"
           }

diff --git a/src/fixtures/local-activities/ts_local_activity.json b/src/fixtures/local-activities/ts_local_activity.json
@@ -22,8 +22,7 @@
         "payloads": [
           {
             "metadata": {
-              "encoding": "anNvbi9wbGFpbg==",
-              "encodingDecoded": "json/plain"
+              "encoding": "anNvbi9wbGFpbg=="
             },
             "data": "Hello, Temporal!"
           }

diff --git a/src/lib/utilities/decode-payload.ts b/src/lib/utilities/decode-payload.ts
@@ -61,11 +61,6 @@ export function decodePayload(
 
   const encoding = atob(String(payload?.metadata?.encoding ?? ''));
 
-  // Help users out with an english encoding
-  if (payload?.metadata) {
-    (payload.metadata.encodingDecoded as unknown as string) = encoding;
-  }
-
   if (encoding?.startsWith('json/')) {
     try {
       const data = parseWithBigInt(atob(String(payload?.data ?? '')));