Skip to content

Commit

Permalink
Set fixed width for select column (#1550)
Browse files Browse the repository at this point in the history
* Set fixed width for select column

* TS hint cleanup

* Use tailwind class instead
  • Loading branch information
laurakwhit authored Aug 14, 2023
1 parent cbef7df commit 15e3b03
Show file tree
Hide file tree
Showing 8 changed files with 6 additions and 22 deletions.
4 changes: 0 additions & 4 deletions src/lib/components/top-nav.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@
import type { NamespaceListItem } from '$lib/types/global';
import { dataEncoder } from '$lib/stores/data-encoder';
import { translate } from '$lib/i18n/translate';
import IconButton from '$lib/holocene/icon-button.svelte';
import { labsMode } from '$lib/stores/labs-mode';
import Button from '$lib/holocene/button.svelte';
import Tooltip from '$lib/holocene/tooltip.svelte';
export let logout: () => void;
export let namespaceList: NamespaceListItem[] = [];
Expand Down
6 changes: 0 additions & 6 deletions src/lib/components/workflow/workflow-stack-trace-error.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,3 @@
</Alert>
</div>
{/if}

<style lang="postcss">
.stack-trace {
@apply relative flex w-full flex-col rounded-xl border-2 border-yellow-700 bg-yellow-50 p-4 text-yellow-900;
}
</style>
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script lang="ts">
import { workflowTableColumns } from '$lib/stores/workflow-table-columns';
import { workflows, updating, loading } from '$lib/stores/workflows';
import { workflows, updating } from '$lib/stores/workflows';
import Drawer from '$lib/holocene/drawer.svelte';
import Icon from '$lib/holocene/icon/icon.svelte';
import PaginatedTable from '$lib/holocene/table/paginated-table.svelte';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@

<style lang="postcss">
.batch-actions-checkbox-table-cell {
@apply min-w-[40px] rounded-tl-lg;
@apply w-10 rounded-tl-lg;
}
.batch-actions-table-cell {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
<script lang="ts">
import { page } from '$app/stores';
import Loading from '$lib/holocene/loading.svelte';
import ProgressBar from '$lib/holocene/progress-bar.svelte';
import type { WorkflowHeader } from '$lib/stores/workflow-table-columns';
import { updating, loading } from '$lib/stores/workflows';
export let pinned = false;
export let columns: WorkflowHeader[];
$: query = $page.url.searchParams.get('query');
</script>

<table class="workflows-summary-table" class:pinned>
Expand Down
6 changes: 1 addition & 5 deletions src/lib/holocene/primitives/menu/menu-item.svelte
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
<script lang="ts">
import {
type ComponentProps,
createEventDispatcher,
getContext,
} from 'svelte';
import { createEventDispatcher, getContext } from 'svelte';
import Tooltip from '$lib/holocene/tooltip.svelte';
import Icon from '$lib/holocene/icon/icon.svelte';
import { MENU_CONTEXT, type MenuContext } from './menu-container.svelte';
Expand Down
2 changes: 1 addition & 1 deletion src/lib/holocene/table/paginated-table.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
export let nextPageButtonLabel: string;
export let previousPageButtonLabel: string;
let tableContainer;
let tableContainer: HTMLDivElement;
$: url = $page.url;
$: perPageParam =
Expand Down
3 changes: 2 additions & 1 deletion src/lib/utilities/get-workflow-relationships.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import type {
ChildWorkflowExecutionFailedEvent,
ChildWorkflowExecutionTerminatedEvent,
ChildWorkflowExecutionTimedOutEvent,
WorkflowEvent,
WorkflowEvents,
} from '$lib/types/events';
import type { WorkflowExecution } from '$lib/types/workflows';
Expand Down Expand Up @@ -40,7 +41,7 @@ export type ChildWorkflowClosedEvent =
| ChildWorkflowExecutionTimedOutEvent
| ChildWorkflowExecutionTerminatedEvent;

export const isChildWorkflowClosedEvent = (event) => {
export const isChildWorkflowClosedEvent = (event: WorkflowEvent) => {
return (
isChildWorkflowExecutionCompletedEvent(event) ||
isChildWorkflowExecutionFailedEvent(event) ||
Expand Down

1 comment on commit 15e3b03

@vercel
Copy link

@vercel vercel bot commented on 15e3b03 Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

holocene – ./

holocene-git-main.preview.thundergun.io
holocene.preview.thundergun.io

Please sign in to comment.