Don't allow multiple status filters of the same value (#2325)

* Check if status exists * Remove allow empty
temporalio · Sep 12, 2024 · 0ffe093 · 0ffe093
1 parent 292196a
commit 0ffe093
Showing 1 changed file with 24 additions and 18 deletions.
diff --git a/src/lib/components/workflow/workflow-counts.svelte b/src/lib/components/workflow/workflow-counts.svelte
@@ -124,25 +124,31 @@
   };
 
   const onStatusClick = (status) => {
-    const filter = {
-      attribute: 'ExecutionStatus',
-      type: SEARCH_ATTRIBUTE_TYPE.KEYWORD,
-      value: status,
-      operator: '',
-      conditional: '=',
-      parenthesis: '',
-    };
-    $workflowFilters = [...$workflowFilters, filter];
-    const searchQuery = toListWorkflowQueryFromFilters(
-      combineFilters($workflowFilters),
+    const statusExists = $workflowFilters.some(
+      (filter) =>
+        filter.attribute === 'ExecutionStatus' && filter.value === status,
     );
-    updateQueryParameters({
-      url: $page.url,
-      parameter: 'query',
-      value: searchQuery,
-      allowEmpty: true,
-      clearParameters: [currentPageKey],
-    });
+
+    if (!statusExists) {
+      const filter = {
+        attribute: 'ExecutionStatus',
+        type: SEARCH_ATTRIBUTE_TYPE.KEYWORD,
+        value: status,
+        operator: '',
+        conditional: '=',
+        parenthesis: '',
+      };
+      $workflowFilters = [...$workflowFilters, filter];
+      const searchQuery = toListWorkflowQueryFromFilters(
+        combineFilters($workflowFilters),
+      );
+      updateQueryParameters({
+        url: $page.url,
+        parameter: 'query',
+        value: searchQuery,
+        clearParameters: [currentPageKey],
+      });
+    }
   };
 
   $: query, namespace, $refresh, fetchCounts();