[Reset] Track child workflows initiated after reset #7210
Merged
+35
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gow
force-pushed
the
cg/reset_before_child_init_1
branch
from
57f6bb3 to
9d6e3b3
Compare
gow
force-pushed
the
cg/reset_before_child_init_2
branch
from
f8ec2ee to
8a05b96
Compare
gow
force-pushed
the
cg/reset_before_child_init_1
branch
from
9d6e3b3 to
39094ab
Compare
gow
force-pushed
the
cg/reset_before_child_init_2
branch
from
29ba43a to
f10c2c4
Compare
gow
force-pushed
the
cg/reset_before_child_init_1
branch
from
39094ab to
6015fef
Compare
gow
force-pushed
the
cg/reset_before_child_init_2
branch
from
f10c2c4 to
5f71593
Compare
gow
force-pushed
the
cg/reset_before_child_init_2
branch
from
5f71593 to
2f2f197
Compare
…nInfo for tracking child workflows post-reset
gow
force-pushed
the
cg/reset_before_child_init_1
branch
from
2814a46 to
695190a
Compare
gow
force-pushed
the
cg/reset_before_child_init_2
branch
from
2f2f197 to
9e4907e
Compare
yycptt
reviewed
Feb 4, 2025
| ) | ||
|
|
||
| var ( | ||
| errWorkflowResetterMaxChildren = serviceerror.NewInternal(fmt.Sprintf("WorkflowResetter encountered max allowed children [%d] while resetting.", maxChildrenInResetMutableState)) |
There was a problem hiding this comment.
What do you mean by invalid arg? I want to include the maxChildrenInResetMutableState value in the error message (in case we change these limits).
Or did you mean something else?
There was a problem hiding this comment.
I mean the error type should be invalid argument, otherwise it counts against SLA.
There was a problem hiding this comment.
Got it. Changed it to InvalidArgument
yycptt
reviewed
Feb 4, 2025
…temporal into cg/reset_before_child_init_2
…efore_child_init_2
yycptt
approved these changes
Feb 5, 2025
| ) | ||
|
|
||
| var ( | ||
| errWorkflowResetterMaxChildren = serviceerror.NewInternal(fmt.Sprintf("WorkflowResetter encountered max allowed children [%d] while resetting.", maxChildrenInResetMutableState)) |
There was a problem hiding this comment.
I mean the error type should be invalid argument, otherwise it counts against SLA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
In this PR I'm recording a set of children that were initialized after the reset point. The children are identified by "workflow_type:workflow_id" key.
Why?
When the parent starts to make progress after reset, it needs to know all the children that were already started after the reset point. In the current iteration of the feature we will use this information to terminate any running child before starting another instance.
We need this information mainly for 2 reasons.
So, we need to record an exact set of children that were observed (at the time of reset) to have been initialized after the reset point.
How did you test it?
Potential risks
Documentation
Is hotfix candidate?