initial prototype: update metadata #7206
Closed
+2,388
−1,922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivs11
commented
Jan 31, 2025
| @@ -7,7 +7,7 @@ retract ( | |||
| v1.26.0 // Published accidentally. | |||
| ) | |||
|
|
|||
| replace go.temporal.io/api => go.temporal.io/api v1.43.2-0.20250130194036-6d83c927eaed | |||
| replace go.temporal.io/api => go.temporal.io/api v1.43.2-0.20250131172531-3415eb526334 | |||
There was a problem hiding this comment.
pointing to my feature branch on api-go: will change once my API PR gets in
Shivs11
commented
Jan 31, 2025
Comment on lines
-330
to
-347
| request := &historyservice.UpdateActivityOptionsRequest{ | ||
| UpdateRequest: &workflowservice.UpdateActivityOptionsByIdRequest{ | ||
| ActivityOptions: &activitypb.ActivityOptions{ | ||
| TaskQueue: &taskqueuepb.TaskQueue{Name: "task_queue_name"}, | ||
| }, | ||
| UpdateMask: &fieldmaskpb.FieldMask{ | ||
| Paths: []string{ | ||
| "TaskQueue.Name", | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| s.mockMutableState.EXPECT().IsWorkflowExecutionRunning().Return(true) | ||
| s.mockMutableState.EXPECT().GetActivityByActivityID(gomock.Any()).Return(nil, false) | ||
| _, err := updateActivityOptions(s.validator, s.mockMutableState, request) | ||
| s.Error(err) | ||
| s.ErrorAs(err, &consts.ErrActivityNotFound) |
There was a problem hiding this comment.
removed unrelated tests for now since they require a merge from main - for now, ignoring this and shall fix it when we merge this branch into main
cc - @carlydf
|
this is merged in versioning-3.1-merge branch 4f38677 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?