feat: Priority annotations #1669
Merged
+192
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuandrew
commented
Apr 7, 2025
Sushisource
approved these changes
Apr 18, 2025
packages/test/src/helpers.ts
Outdated
Comment on lines
41
to
42
| // TODO: Remove after next CLI release | ||
| export const TESTS_CLI_VERSION = inWorkflowContext() ? '' : 'v1.3.1-priority.0'; |
There was a problem hiding this comment.
This should be done by just setting the env var in the GH workflows. See here: https://github.com/temporalio/sdk-typescript/pull/1679/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR22
| @@ -122,6 +123,11 @@ export interface ActivityOptions { | |||
| * @experimental The Worker Versioning API is still being designed. Major changes are expected. | |||
| */ | |||
| versioningIntent?: VersioningIntent; | |||
|
|
|||
| /** | |||
| * Priority of an activity | |||
There was a problem hiding this comment.
Suggested change
| * Priority of an activity | |
| * Priority of this activity |
packages/activity/src/index.ts
Outdated
| @@ -198,6 +198,10 @@ export interface Info { | |||
| * For Local Activities, this is set to the Workflow's Task Queue. | |||
| */ | |||
| readonly taskQueue: string; | |||
| /** | |||
| * Priority of an Activity | |||
There was a problem hiding this comment.
Suggested change
| * Priority of an Activity | |
| * Priority of this Activity |
packages/workflow/src/interfaces.ts
Outdated
| @@ -183,6 +184,11 @@ export interface WorkflowInfo { | |||
| readonly currentBuildId?: string; | |||
|
|
|||
| readonly unsafe: UnsafeWorkflowInfo; | |||
|
|
|||
| /** | |||
| * Priority of a workflow | |||
There was a problem hiding this comment.
Suggested change
| * Priority of a workflow | |
| * Priority of this workflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added priority settings on workflow, child workflow, and activities. Also updated tests to use CLI `v1.3.1-priority.0', until a new CLI release contains priority support.
Why?
priorities
Checklist
Closes [Feature Request] Support Priority Annotations #1620
How was this tested:
Added integration tests