-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/adds activities providers #759
base: main
Are you sure you want to change the base?
Feature/adds activities providers #759
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrmm, I think many users that need activity discovery are using their own decorators and capturing in a big list/dict. If we want to make activity discovery more explicit, we should also consider providing other definition information such as the name, whether they have disabled thread-raise on cancel, etc.
Also, many people use different activities in different workers in the same process, so not sure it makes sense to have a "provider" API as if there is only one worker and all activities will belong to it. Users need to individually choose which activities to give to which workers.
I could see maybe exposing the activity definition and could see maybe exposing a way to get all known definitions that provide a @activity.defn
decorator, but in general different users combine/collect activities in different ways and I'm not sure we want a "blessed" one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It covers my use cases and I am only one user. Is there any way that we can ask devs and get numbers from the community on if they want this MR or something like it?
Also not suggesting that this will work for all users, only some.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately with our open source nature it is hard to gauge interest unless it is something that is a pain point for users. I do think we could consider exposing all activity definitions in a static/global way, though that's not the same thing as a list you may want to map to callables and then pass into a worker. We have not done this traditionally in any other SDK, instead relying on users to collect their activities in their preferred way (though we have integrated with things like Sprint Boot in Java).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a Slack temporal community with +7,500 members in the #python-sdk, channel, may I ask them there?
What was changed
ActivitiesProvider.get_activities_from_instance
+ActivitiesProvider.get_activities_from_cls
) to get activities from classes that inherit from ActivitiesProviderget_activities
to get activities from a python moduleWhy?
These are useful to my code base to extract activities from classes and module
Checklist
Closes [Feature Request] Suggest Providing activities extraction utilities to get them from a class and a module #758
How was this tested:
Yes, not sure where docs are generated from, where should this be added?