Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wheel to dev-dependencies #457

Merged
merged 8 commits into from
Jan 11, 2024
Merged

Add wheel to dev-dependencies #457

merged 8 commits into from
Jan 11, 2024

Conversation

josh-berry
Copy link
Contributor

No description provided.

@josh-berry josh-berry requested a review from a team as a code owner January 8, 2024 22:01
@CLAassistant
Copy link

CLAassistant commented Jan 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@josh-berry
Copy link
Contributor Author

Confirmed all the binary builds work correctly with this change. https://github.com/temporalio/sdk-python/actions/runs/7454061042?pr=457

cretz
cretz reviewed Jan 9, 2024
View reviewed changes
pyproject.toml Outdated
@@ -64,6 +64,9 @@ twine = "^4.0.1"
opentelemetry = ["opentelemetry-api", "opentelemetry-sdk"]
grpc = ["grpcio"]

[tool.poetry.group.dev.dependencies]
wheel = "^0.42.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be moved to the tool.poetry.dev-dependencies section above? I know that newer poetry has it like this, but for older ones (which some envs are forced to use I think), we already have a list above.

@cretz
Copy link
Member

cretz commented Jan 11, 2024

@josh-berry - LGTM, can just remove your branch now and we can probably merge

@josh-berry josh-berry requested a review from cretz January 11, 2024 21:28
cretz
cretz approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cretz cretz merged commit 0bff022 into main Jan 11, 2024
14 checks passed
@cretz cretz deleted the josh/add-wheel-to-dev-deps branch January 11, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josh-berry @CLAassistant @cretz