Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip magic methods in Activity classes #572

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Skip magic methods in Activity classes #572

merged 1 commit into from
Feb 19, 2025

Conversation

roxblnfk
Copy link
Collaborator

What was changed

Magic methods that was not marked by the ActivityMethod attribute will not be registered as activity methods

Checklist

  1. Closes [Feature Request] Stop registering magic methods as Activity methods #566
  2. How was this tested: added tests

Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 4:07pm

@roxblnfk roxblnfk merged commit 60a0c66 into master Feb 19, 2025
110 of 114 checks passed
@roxblnfk roxblnfk deleted the magic-activity branch February 19, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Stop registering magic methods as Activity methods
2 participants