Java test server support for attaching links to signal and signal with start requests #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Feb 10, 2025
...test-server/src/main/java/io/temporal/internal/testservice/TestWorkflowMutableStateImpl.java
Outdated
Show resolved
Hide resolved
temporal-test-server/src/test/java/io/temporal/testserver/functional/SignalLinksTest.java
Outdated
Show resolved
Hide resolved
bergundy
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Approving based on the test. Please fix the import changes.
Will defer to @Quinn-With-Two-Ns for the final approval.
Quinn-With-Two-Ns
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Java test server support for attaching links to signal and signal with start requests
Why?
We need links support
Checklist
Closes
SDK-3344
How was this tested:
Unit tests
3. Any docs updates needed?