Remove Nexus sync client handler #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
approved these changes
Feb 7, 2025
| @@ -52,9 +36,8 @@ public static <T, R> OperationHandler<T, R> sync( | |||
| public static <T, R> OperationHandler<T, R> fromWorkflowMethod( | |||
| WorkflowMethodFactory<T, R> startMethod) { | |||
| return new RunWorkflowOperation<>( | |||
There was a problem hiding this comment.
Doesn't have to be in this PR but I would to call this WorkflowRunOperation across all SDKs.
| * Get a {@link WorkflowClient} that can be used to start interact with the Temporal service from | ||
| * a Nexus handler. | ||
| */ | ||
| WorkflowClient getWorkflowClient(); |
There was a problem hiding this comment.
Maybe add a method to get the nexus context too?
There was a problem hiding this comment.
If a use case comes up yes, at least internally.
cretz
approved these changes
Feb 7, 2025
Sushisource
approved these changes
Feb 7, 2025
Quinn-With-Two-Ns
force-pushed
the
remove-sync-client-op
branch
from
56d6c85 to
2099173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Nexus sync client handler, users can now get the client with
Nexus.getOperationContext().getWorkflowClient()