Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Graal reflection config for UwS #2363

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Add Graal reflection config for UwS #2363

merged 1 commit into from
Feb 18, 2025

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Add Graal reflection config for UwS. Generated by running UwS tests with tracing agent

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner January 7, 2025 17:29
cretz
cretz approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share how you generated this? Were the contributing notes enough or did you have to do some manual things? No need to explain in depth or anything (especially if we hope to improve in the future), just curious.

@Quinn-With-Two-Ns
Copy link
Contributor Author

Can you share how you generated this?

I just build the test server and ran with the tracing agent. When I get us onto the official plugin it should be a lot more straightforward

@Quinn-With-Two-Ns Quinn-With-Two-Ns force-pushed the update-graal-reflection-config branch from 19a15f5 to e0778bb Compare February 18, 2025 22:08
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 436d080 into temporalio:master Feb 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @cretz