Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating SDK, adding OpenTelemetry #33

Merged
merged 8 commits into from
Nov 27, 2023
Merged

Updating SDK, adding OpenTelemetry #33

merged 8 commits into from
Nov 27, 2023

Conversation

msmakouz
Copy link
Contributor

@msmakouz msmakouz commented Jun 12, 2023 •
edited
Loading

What was changed

  1. Updated Temporal PHP SDK
  2. Added OpenTelemetry interceptors
  3. Min PHP 8.1

Waiting:

Sushisource
Sushisource approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM pending possible changes to the actual OTel interceptor PR

@roxblnfk roxblnfk mentioned this pull request Oct 23, 2023
Merged
@roxblnfk roxblnfk merged commit 0858a40 into temporalio:master Nov 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

@wolfy-j wolfy-j wolfy-j approved these changes

@roxblnfk roxblnfk roxblnfk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msmakouz @Sushisource @wolfy-j @roxblnfk