Accepting Tiho's suggestion to process signals in-loop, reducing use …

…of timers
temporalio · Jul 3, 2024 · f558c09 · f558c09
1 parent 51968b5
commit f558c09
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/core/src/main/java/io/temporal/samples/hello/HelloAccumulator.java b/core/src/main/java/io/temporal/samples/hello/HelloAccumulator.java
@@ -215,11 +215,14 @@ public String accumulateGreetings(
       // - if exit signal is received, process any remaining signals and exit
       do {
 
-        Workflow.await(MAX_AWAIT_TIME, () -> !unprocessedGreetings.isEmpty() || exitRequested);
+        boolean timedout =
+            !Workflow.await(MAX_AWAIT_TIME, () -> !unprocessedGreetings.isEmpty() || exitRequested);
 
-        if (!unprocessedGreetings.isEmpty()) {
+        while (!unprocessedGreetings.isEmpty()) {
           processGreeting(unprocessedGreetings.removeFirst());
-        } else {
+        }
+
+        if (exitRequested || timedout) {
           String greetEveryone = processGreetings(greetings);
 
           if (unprocessedGreetings.isEmpty()) {