Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ports for service and enable istio support out-of-the-box #639

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

Hronom
Copy link
Contributor

@Hronom Hronom commented Jan 29, 2025

What was changed

Fix ports for service and enable Istio support out-of-the-box.

Why?

Checklist

  1. Closes Temporal services are not starting when deployed in istio enabled namespace #338

  2. How was this tested:

Tested on cluster with Istio enabled and strict mTLS.

  1. Any docs updates needed?

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Hronom
Copy link
Contributor Author

Hronom commented Jan 29, 2025

Also I signed the CLA, not sure why the old comment is drawn

@Hronom Hronom requested a review from robholland January 30, 2025 15:05
@Hronom Hronom force-pushed the main branch 4 times, most recently from 0456cf4 to c64ce2c Compare January 30, 2025 15:26
Copy link
Contributor

@robholland robholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tweak the docs a little as per suggestions, but otherwise happy to merge. Thanks for your patience while exploring alternatives.

charts/temporal/templates/server-deployment.yaml Outdated Show resolved Hide resolved
charts/temporal/templates/server-deployment.yaml Outdated Show resolved Hide resolved
charts/temporal/templates/server-service.yaml Outdated Show resolved Hide resolved
charts/temporal/templates/server-service.yaml Show resolved Hide resolved
@Hronom
Copy link
Contributor Author

Hronom commented Jan 31, 2025

@robholland applied suggested changes. Please trigger that job that is currently blocking the merge. Thanks!

@Hronom
Copy link
Contributor Author

Hronom commented Jan 31, 2025

@robholland one more time, I merged suggestions. Seems like only you can merge it. Let me know if I missed anything

@robholland robholland merged commit 66eccf7 into temporalio:main Feb 1, 2025
3 checks passed
@robholland
Copy link
Contributor

Thanks for your work and patience :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporal services are not starting when deployed in istio enabled namespace
3 participants