-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ports for service and enable istio support out-of-the-box #639
Conversation
|
Also I signed the CLA, not sure why the old comment is drawn |
0456cf4
to
c64ce2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please tweak the docs a little as per suggestions, but otherwise happy to merge. Thanks for your patience while exploring alternatives.
@robholland applied suggested changes. Please trigger that job that is currently blocking the merge. Thanks! |
Signed-off-by: Yevhen Tienkaiev <[email protected]>
@robholland one more time, I merged suggestions. Seems like only you can merge it. Let me know if I missed anything |
Thanks for your work and patience :) |
What was changed
Fix ports for service and enable Istio support out-of-the-box.
Why?
Checklist
Closes Temporal services are not starting when deployed in istio enabled namespace #338
How was this tested:
Tested on cluster with Istio enabled and strict mTLS.