Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs onboarding - contributing guidance #3121

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

jsundai
Copy link
Contributor

@jsundai jsundai commented Oct 2, 2024

What does this PR do?

Notes to reviewers

@jsundai jsundai requested a review from a team as a code owner October 2, 2024 23:02
@jsundai jsundai marked this pull request as draft October 3, 2024 14:03
Copy link
Contributor

@tomwheeler tomwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My one request would be to rename IA-guidance.md as ia-guidance.md so that it's consistent with the other file names.

I doublechecked just now, and every other Markdown file in the documentation repo uses lowercase letters exclusively. Since UNIX systems tend to have case-sensitive filesystem, we should avoid arbitrarily mixing case in filenames because it can create trouble down the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants