maintenance: yarn format on repo #3116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairlydurable
approved these changes
Sep 30, 2024
jsundai
commented
Oct 2, 2024
| @@ -316,28 +317,30 @@ To send an Update to a Workflow Execution, you can: | |||
| This code fetches an Update result: | |||
|
|
|||
| ```csharp | |||
There was a problem hiding this comment.
This will actually be a fix of the code sample because the formatting is off so it's not showing correctly on the site.
jsundai
commented
Oct 2, 2024
|
|
||
| For more details, see the "Async handlers" section. | ||
| For more details, see the "Async handlers" section. |
There was a problem hiding this comment.
This looks like this needs a link.
jsundai
commented
Oct 2, 2024
| @@ -595,7 +593,7 @@ When sending a Signal, Update, or Query to a Workflow, your Client might encount | |||
| You'll receive a [`Temporalio.Exceptions.RpcException`](https://dotnet.temporal.io/api/Temporalio.Exceptions.RpcException.html) exception whose `Code` property is [`RpcException.StatusCode`](https://dotnet.temporal.io/api/Temporalio.Exceptions.RpcException.StatusCode.html) with a status of `Unavailable` (after some retries). | |||
|
|
|||
| - **The Workflow does not exist**: | |||
| You'll receive a [`Temporalio.Exceptions.RpcException`](https://dotnet.temporal.io/api/Temporalio.Exceptions.RpcException.html) exception whose `Code` property is [`RpcException.StatusCode`](https://dotnet.temporal.io/api/Temporalio.Exceptions.RpcException.StatusCode.html) with a status of `NotFound`. | |||
| You'll receive a [`Temporalio.Exceptions.RpcException`](https://dotnet.temporal.io/api/Temporalio.Exceptions.RpcException.html) exception whose `Code` property is [`RpcException.StatusCode`](https://dotnet.temporal.io/api/Temporalio.Exceptions.RpcException.StatusCode.html) with a status of `NotFound`. | |||
|
|
|||
| See [Exceptions in message handlers](/encyclopedia/workflow-message-passing#exceptions) for a non–.NET-specific discussion of this topic. | |||
There was a problem hiding this comment.
Could probably be rephrased. "non–.NET-specific"
jsundai
commented
Oct 2, 2024
| @@ -614,18 +612,18 @@ When working with Updates, you may encounter these errors: | |||
| - **No Workflow Workers are polling the Task Queue**: | |||
| Your request will be retried by the SDK Client indefinitely. | |||
| Use a `CancellationToken` in your [RPC options](https://dotnet.temporal.io/api/Temporalio.Client.WorkflowUpdateOptions.html#Temporalio_Client_WorkflowUpdateOptions_Rpc) to cancel the Update. | |||
| This raises a [Temporalio.Exceptions.WorkflowUpdateRpcTimeoutOrCanceledException](https://dotnet.temporal.io/api/Temporalio.Exceptions.WorkflowUpdateRpcTimeoutOrCanceledException.html) exception . | |||
| This raises a [Temporalio.Exceptions.WorkflowUpdateRpcTimeoutOrCanceledException](https://dotnet.temporal.io/api/Temporalio.Exceptions.WorkflowUpdateRpcTimeoutOrCanceledException.html) exception . | |||
There was a problem hiding this comment.
There's an extra space here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
the number of files where yarn format hasn't been run is getting increasingly large 🫣
doing this maintenance task.
Notes to reviewers
need to check code samples that were auto-edited before review.