Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Billing updates #3066

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Billing updates #3066

wants to merge 23 commits into from

Conversation

UPatel12
Copy link
Contributor

@UPatel12 UPatel12 commented Sep 5, 2024

What does this PR do?

updating the billing page

  • added the new credits functionality
  • we also changed the location of the billing page in the UI so made updated to the a few other sections

Notes to reviewers

@angelazhou32 @fairlydurable

@UPatel12 UPatel12 requested a review from a team as a code owner September 5, 2024 19:45
@fairlydurable
Copy link
Contributor

Jira ticket: EDU-3125

fairlydurable
fairlydurable requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@fairlydurable fairlydurable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to leave explanations for why each suggestion was made, except for the final list that all shared the same explanation.

I recommend a revisit to this document to bring it into Documentation team compliance but it is not urgent at this time.

docs/production-deployment/cloud/billing-and-cost.mdx Outdated Show resolved Hide resolved
docs/production-deployment/cloud/billing-and-cost.mdx Outdated Show resolved Hide resolved
docs/production-deployment/cloud/billing-and-cost.mdx Outdated Show resolved Hide resolved
docs/production-deployment/cloud/billing-and-cost.mdx Show resolved Hide resolved
docs/production-deployment/cloud/billing-and-cost.mdx Outdated Show resolved Hide resolved
docs/production-deployment/cloud/billing-and-cost.mdx Outdated Show resolved Hide resolved
docs/production-deployment/cloud/billing-and-cost.mdx Outdated Show resolved Hide resolved
docs/production-deployment/cloud/billing-and-cost.mdx Outdated Show resolved Hide resolved
docs/production-deployment/cloud/billing-and-cost.mdx Outdated Show resolved Hide resolved
docs/production-deployment/cloud/billing-and-cost.mdx Outdated Show resolved Hide resolved
fairlydurable
fairlydurable reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@fairlydurable fairlydurable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this one on the wrong line. Should be correct now.

UPatel12 and others added 11 commits September 6, 2024 12:44
@UPatel12 @stevekinney
Update docs/production-deployment/cloud/billing-and-cost.mdx
b0e211e 
Co-authored-by: Steve Kinney <[email protected]>
@UPatel12 @fairlydurable
Update docs/production-deployment/cloud/billing-and-cost.mdx
fdc801f 
Co-authored-by: Erica Sadun <[email protected]>
@UPatel12 @fairlydurable
Update docs/production-deployment/cloud/billing-and-cost.mdx
9caab13 
Co-authored-by: Erica Sadun <[email protected]>
@UPatel12 @fairlydurable
Update docs/production-deployment/cloud/billing-and-cost.mdx
3f843b7 
Co-authored-by: Erica Sadun <[email protected]>
@UPatel12 @fairlydurable
Update docs/production-deployment/cloud/billing-and-cost.mdx
20320c3 
Co-authored-by: Erica Sadun <[email protected]>
@UPatel12 @fairlydurable
Update docs/production-deployment/cloud/billing-and-cost.mdx
fc8a863 
Co-authored-by: Erica Sadun <[email protected]>
@UPatel12 @fairlydurable
Update docs/production-deployment/cloud/billing-and-cost.mdx
4a6b152 
Co-authored-by: Erica Sadun <[email protected]>
@UPatel12 @fairlydurable
Update docs/production-deployment/cloud/billing-and-cost.mdx
b36e3da 
Co-authored-by: Erica Sadun <[email protected]>
@UPatel12 @fairlydurable
Update docs/production-deployment/cloud/billing-and-cost.mdx
19e1f5e 
Co-authored-by: Erica Sadun <[email protected]>
@UPatel12 @fairlydurable
Update docs/production-deployment/cloud/billing-and-cost.mdx
9608db3 
Co-authored-by: Erica Sadun <[email protected]>
@UPatel12 @fairlydurable
Update docs/production-deployment/cloud/billing-and-cost.mdx
42c00aa 
Co-authored-by: Erica Sadun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekinney stevekinney stevekinney left review comments

@fairlydurable fairlydurable fairlydurable requested changes

@angelazhou32 angelazhou32 Awaiting requested review from angelazhou32

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UPatel12 @fairlydurable @stevekinney