Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove automatic dependency upgrade on proto update #176

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Sep 4, 2024

What changed?

Previously we automatically updated all dependencies on every proto submodule update GitHub workflow (triggered by merge in api repo). This means that we are forcing users to upgrade things like gRPC unnecessarily. This removes that step from the proto submodule update.

@cretz cretz requested review from a team as code owners September 4, 2024 18:14
Copy link
Contributor

@tdeebswihart tdeebswihart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cretz cretz merged commit c4d79a5 into temporalio:master Sep 4, 2024
3 checks passed
@cretz cretz deleted the remove-auto-dep-update branch September 4, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants