Bump Go version for CI builds to 1.22 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lina-temporal
changed the title
cretz
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Ug, I think this points out a problem we have with our automated merge script. For whatever reason we are updating every dependency blindly when we update protos in that GH workflow. This forces every user we have to upgrade their versions even if we/they don't need to.
Approving this, but am going to bring this up to team. I think forced automatic dependency upgrades are a bad thing for what is effectively Temporal's most used library by users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks