Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GHA update-proto.yml #164

Merged
merged 1 commit into from
May 29, 2024
Merged

Update GHA update-proto.yml #164

merged 1 commit into from
May 29, 2024

Conversation

rodrigozhou
Copy link
Contributor

@rodrigozhou rodrigozhou commented May 29, 2024 •
edited
Loading

What changed?

  • Update actions versions.
  • Add optional input to update protos of a specific branch
  • Use Github token instead of the secrets COMMANDER_DATA_TOKEN
  • Fix bug when the commit message contains double-quotes.

Why?

How did you test it?

Potential risks

@rodrigozhou rodrigozhou requested review from a team as code owners May 29, 2024 20:00
@rodrigozhou rodrigozhou force-pushed the rodrigozhou/fix-update-proto branch 2 times, most recently from e6aada4 to aa115bf Compare May 29, 2024 20:18
cretz
cretz approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the last attempt at this failed and we had to revert, hopefully this one works

.github/workflows/update-proto.yml Outdated Show resolved Hide resolved
@rodrigozhou rodrigozhou force-pushed the rodrigozhou/fix-update-proto branch from aa115bf to 86f7d7c Compare May 29, 2024 20:48
@rodrigozhou rodrigozhou merged commit a65b149 into master May 29, 2024
3 checks passed
@rodrigozhou rodrigozhou deleted the rodrigozhou/fix-update-proto branch May 29, 2024 20:51
@rodrigozhou rodrigozhou mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodrigozhou @cretz