-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace gogo protobuf with google's protobuf v2 compiler #119
Commits on Sep 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e344d3e - Browse repository at this point
Copy the full SHA e344d3eView commit details -
Remove proxygenerator's reliance on gogo/protobuf
This wasn't too bad, though the variable names disappeared from the go-parsed type signature of our RPC specs so I had to generate variable names manually /shrug
Configuration menu - View commit details
-
Copy full SHA for a372766 - Browse repository at this point
Copy the full SHA a372766View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bef229 - Browse repository at this point
Copy the full SHA 2bef229View commit details -
Google's protobuf compiler doesn't allow you to customize JSON formatting and forking it like we did with gogo's is no simple matter (it depends on a large number of internal packages...). I'm deleting it for now to unblock myself while I wait to discuss this with our HTTP API team tomorrow
Configuration menu - View commit details
-
Copy full SHA for e660f0b - Browse repository at this point
Copy the full SHA e660f0bView commit details
Commits on Sep 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 205b263 - Browse repository at this point
Copy the full SHA 205b263View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce9a5b2 - Browse repository at this point
Copy the full SHA ce9a5b2View commit details
Commits on Sep 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 69c53d5 - Browse repository at this point
Copy the full SHA 69c53d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13f2c44 - Browse repository at this point
Copy the full SHA 13f2c44View commit details -
Update interceptor to not copy locks
Go's protobuf-generated code embeds locks, so by copying the contents of the object we violate the lock's guarantees. We'll return the new payload and overwrite the old instead
Configuration menu - View commit details
-
Copy full SHA for 716a83c - Browse repository at this point
Copy the full SHA 716a83cView commit details
Commits on Oct 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f9fb8c6 - Browse repository at this point
Copy the full SHA f9fb8c6View commit details
Commits on Oct 3, 2023
-
Port history loading over from the SDK
We'll want to use this in the CLI as well to allow users to update old histories
Configuration menu - View commit details
-
Copy full SHA for 6fdbb4c - Browse repository at this point
Copy the full SHA 6fdbb4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 389ae08 - Browse repository at this point
Copy the full SHA 389ae08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65454a6 - Browse repository at this point
Copy the full SHA 65454a6View commit details -
Remove options pattern from history.LoadFromJSON
There's one option and its pretty much always supplied; this was an over-eager change.
Configuration menu - View commit details
-
Copy full SHA for 7efc384 - Browse repository at this point
Copy the full SHA 7efc384View commit details -
Add proto-conversion helpers for Time and Durations
Pulled these over form the SDK and cleaned up the naming. common.ThingPtr and common.ThingValue don't roll off the tongue as nicely as thing.Proto and thing.Value.
Configuration menu - View commit details
-
Copy full SHA for 6cda8db - Browse repository at this point
Copy the full SHA 6cda8dbView commit details -
Filter out non-go files and make sure to rewrite uses of these enums
Configuration menu - View commit details
-
Copy full SHA for de61875 - Browse repository at this point
Copy the full SHA de61875View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c4c150 - Browse repository at this point
Copy the full SHA 7c4c150View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72ba345 - Browse repository at this point
Copy the full SHA 72ba345View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7493bd - Browse repository at this point
Copy the full SHA b7493bdView commit details -
Fix history load tests and actually run them
Tests are now run by default (as they should be)
Configuration menu - View commit details
-
Copy full SHA for cbe2bb4 - Browse repository at this point
Copy the full SHA cbe2bb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d410a2a - Browse repository at this point
Copy the full SHA d410a2aView commit details
Commits on Oct 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 428211c - Browse repository at this point
Copy the full SHA 428211cView commit details
Commits on Oct 9, 2023
-
Move codegen helpers to this repo and update
We're back to proto for codegen too
Configuration menu - View commit details
-
Copy full SHA for dd417ed - Browse repository at this point
Copy the full SHA dd417edView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5b4a15 - Browse repository at this point
Copy the full SHA b5b4a15View commit details -
Correctly translate JSON enums for types which contain themselves
My previous approach failed to fix enums in nested failures. Rather than hardcode logic for handling failures specifically I took a step back and approached it another way entirely: tracking paths to fix for each proto message that is reachable from the History message. With this approach we can handle any future type that can contain itself without code changes
Configuration menu - View commit details
-
Copy full SHA for 1ca3f12 - Browse repository at this point
Copy the full SHA 1ca3f12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62b7da4 - Browse repository at this point
Copy the full SHA 62b7da4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec12a7f - Browse repository at this point
Copy the full SHA ec12a7fView commit details
Commits on Oct 10, 2023
-
It turns out we serialize far more than just history in JSON so we need a mechanism to support the old enum format for arbitrary proto objects. The approach I've taken is thread-safe so we don't need to care who is serializing what at any point in time (and I've minimized the critical sections). Most operations will only ever take the registry's read lock so this shouldn't be a bottleneck
Configuration menu - View commit details
-
Copy full SHA for 7515ef0 - Browse repository at this point
Copy the full SHA 7515ef0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17191bd - Browse repository at this point
Copy the full SHA 17191bdView commit details -
Rename jsonpb to temporalproto
This package will eventually contain all our extensions to google's v2 proto package, including: - Enum casing translation - Shorthand JSON support
Configuration menu - View commit details
-
Copy full SHA for 16ae34d - Browse repository at this point
Copy the full SHA 16ae34dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 910c300 - Browse repository at this point
Copy the full SHA 910c300View commit details -
Configuration menu - View commit details
-
Copy full SHA for 837039d - Browse repository at this point
Copy the full SHA 837039dView commit details -
Configuration menu - View commit details
-
Copy full SHA for aae8509 - Browse repository at this point
Copy the full SHA aae8509View commit details -
Generate functions to convert enum values from string
I discovered _even more_ places where we use our PascalCase enums so we'll just generate the code needed to handle it.
Configuration menu - View commit details
-
Copy full SHA for 1d57552 - Browse repository at this point
Copy the full SHA 1d57552View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8435832 - Browse repository at this point
Copy the full SHA 8435832View commit details
Commits on Oct 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 47d4e43 - Browse repository at this point
Copy the full SHA 47d4e43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c04e0d - Browse repository at this point
Copy the full SHA 4c04e0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e958a1 - Browse repository at this point
Copy the full SHA 6e958a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c522e4 - Browse repository at this point
Copy the full SHA 2c522e4View commit details
Commits on Oct 12, 2023
-
Rewrite proto enum String methods
We rely on the old JSON string values of our proto enums heavily; they appear in error messages, the visibility search interface, and our metric tags. Rather than rewrite them at every callsite we decided to simply rewrite the String methods to give us what we want. This is lower effort and less maintenance than maintaining a fork of the protojson marshaling infrastructure.
Configuration menu - View commit details
-
Copy full SHA for 229d40f - Browse repository at this point
Copy the full SHA 229d40fView commit details -
This will be go-installed by the Server so needs a more obvious name.
Configuration menu - View commit details
-
Copy full SHA for 0909eae - Browse repository at this point
Copy the full SHA 0909eaeView commit details
Commits on Oct 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6469411 - Browse repository at this point
Copy the full SHA 6469411View commit details
Commits on Oct 18, 2023
-
Port reflection helpers over from the server
These are becoming necessary elsewhere
Configuration menu - View commit details
-
Copy full SHA for 3a4d6e3 - Browse repository at this point
Copy the full SHA 3a4d6e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef5a505 - Browse repository at this point
Copy the full SHA ef5a505View commit details -
Configuration menu - View commit details
-
Copy full SHA for 966fdd4 - Browse repository at this point
Copy the full SHA 966fdd4View commit details -
Merge reflect and proto extensions
It's all proto's fault anyways
Configuration menu - View commit details
-
Copy full SHA for a2111ee - Browse repository at this point
Copy the full SHA a2111eeView commit details
Commits on Oct 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a9bd390 - Browse repository at this point
Copy the full SHA a9bd390View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1f1432 - Browse repository at this point
Copy the full SHA f1f1432View commit details
Commits on Oct 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a4867f8 - Browse repository at this point
Copy the full SHA a4867f8View commit details
Commits on Oct 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 447c31e - Browse repository at this point
Copy the full SHA 447c31eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfe668b - Browse repository at this point
Copy the full SHA bfe668bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 098edea - Browse repository at this point
Copy the full SHA 098edeaView commit details
Commits on Oct 30, 2023
-
I've no idea why these two mocks keep swapping names. It's irritating
Configuration menu - View commit details
-
Copy full SHA for 872ab2d - Browse repository at this point
Copy the full SHA 872ab2dView commit details -
Remove temporalproto.PublicMethods
This is only used by the server so should stay there
Configuration menu - View commit details
-
Copy full SHA for ba122e5 - Browse repository at this point
Copy the full SHA ba122e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5f08f0 - Browse repository at this point
Copy the full SHA c5f08f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3f2b0b - Browse repository at this point
Copy the full SHA e3f2b0bView commit details
Commits on Nov 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9088f4d - Browse repository at this point
Copy the full SHA 9088f4dView commit details
Commits on Nov 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 59e4eda - Browse repository at this point
Copy the full SHA 59e4edaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2507a24 - Browse repository at this point
Copy the full SHA 2507a24View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8d3c66 - Browse repository at this point
Copy the full SHA f8d3c66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 080d999 - Browse repository at this point
Copy the full SHA 080d999View commit details