Skip to content

Commit

Permalink
Replace gogo protobuf with google's protobuf v2 compiler (#317)
Browse files Browse the repository at this point in the history
**What changed?**

gogo/protobuf has been replaced with Google's official go compiler.

I also changed our code generation to use buf as it was slightly easier to manage plugin versions, though I may revert that.

**Why?**

gogo/protobuf has been deprecated for some time and the community is moving on, building new tools (like vtproto) atop google's v2 compiler.

**Breaking changes**

-  in proto structs will now be [timestamppb.Timestamp](https://pkg.go.dev/google.golang.org/[email protected]/types/known/timestamppb#section-documentation)
-  will now be [durationpb.Duration](https://pkg.go.dev/google.golang.org/protobuf/types/known/durationpb)
- V2-generated structs embed locks, so you cannot dereference them willy-nilly.  will scream at you about this
- Proto enums will, when formatted to JSON, now be in  rather than . We decided (in discussion with the SDK team) that now was as good a time as any to rip the bandage off
  • Loading branch information
tdeebswihart committed Nov 21, 2023
1 parent 436d5b2 commit 89e3fc1
Show file tree
Hide file tree
Showing 16 changed files with 2,970 additions and 4,041 deletions.
150 changes: 72 additions & 78 deletions batch/v1/message.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 89e3fc1

Please sign in to comment.