feat(database): add explicit ConnectionClosed exception

src/Tempest/Database/src/ConnectionInitializer.php

@@ -7,6 +7,7 @@
 use Tempest\Container\Container;
 use Tempest\Container\Initializer;
 use Tempest\Container\Singleton;
+use Tempest\Core\AppConfig;
 
 final class ConnectionInitializer implements Initializer
 {
@@ -16,7 +17,7 @@ final class ConnectionInitializer implements Initializer
     public function initialize(Container $container): Connection
     {
         // Reuse same connection instance in unit tests
-        if (self::$instance !== null) {
+        if (self::$instance !== null && $container->get(AppConfig::class)->environment->isTesting()) {
             return self::$instance;
         }
 

src/Tempest/Database/src/Exceptions/ConnectionClosed.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Database\Exceptions;
+
+final class ConnectionClosed extends DatabaseException
+{
+    public function __construct()
+    {
+        parent::__construct('Connection is closed');
+    }
+}

src/Tempest/Database/src/PDOConnection.php

@@ -7,6 +7,7 @@
 use PDO;
 use PDOStatement;
 use Tempest\Database\Connections\DatabaseConnection;
+use Tempest\Database\Exceptions\ConnectionClosed;
 
 final class PDOConnection implements Connection
 {
@@ -18,26 +19,46 @@ public function __construct(private readonly DatabaseConnection $connection)
 
     public function beginTransaction(): bool
     {
+        if ($this->pdo === null) {
+            throw new ConnectionClosed();
+        }
+
         return $this->pdo->beginTransaction();
     }
 
     public function commit(): bool
     {
+        if ($this->pdo === null) {
+            throw new ConnectionClosed();
+        }
+
         return $this->pdo->commit();
     }
 
     public function rollback(): bool
     {
+        if ($this->pdo === null) {
+            throw new ConnectionClosed();
+        }
+
         return $this->pdo->rollBack();
     }
 
     public function lastInsertId(): false|string
     {
+        if ($this->pdo === null) {
+            throw new ConnectionClosed();
+        }
+
         return $this->pdo->lastInsertId();
     }
 
     public function prepare(string $sql): false|PDOStatement
     {
+        if ($this->pdo === null) {
+            throw new ConnectionClosed();
+        }
+
         return $this->pdo->prepare($sql);
     }
 

src/Tempest/Database/tests/PDOConnectionTest.php

@@ -0,0 +1,85 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Database\Tests;
+
+use Generator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\TestCase;
+use Tempest\Database\Connections\SQLiteConnection;
+use Tempest\Database\Exceptions\ConnectionClosed;
+use Tempest\Database\PDOConnection;
+
+/**
+ * @internal
+ */
+final class PDOConnectionTest extends TestCase
+{
+    private const string PATH = ':memory:';
+
+    #[DataProvider('provideQueryMethods')]
+    public function test_connection_must_be_open(string $method, array $params): void
+    {
+        $this->expectException(ConnectionClosed::class);
+
+        $connection = new PDOConnection(new SQLiteConnection(self::PATH));
+
+        $connection->$method(...$params);
+    }
+
+    #[DataProvider('provideQueryMethods')]
+    public function test_close_must_be_open(string $method, array $params): void
+    {
+        $this->expectException(ConnectionClosed::class);
+
+        $connection = new PDOConnection(new SQLiteConnection(self::PATH));
+        $connection->connect();
+        $connection->close();
+
+        $connection->$method(...$params);
+    }
+
+    public static function provideQueryMethods(): Generator
+    {
+        yield 'lastInsertId' => ['lastInsertId', []];
+        yield 'commit' => ['commit', []];
+        yield 'rollback' => ['rollback', []];
+        yield 'beginTransaction' => ['beginTransaction', []];
+        yield 'prepare' => ['prepare', ['select 1']];
+    }
+
+    public function test_commit(): void
+    {
+        $connection = new PDOConnection(new SQLiteConnection(self::PATH));
+        $connection->connect();
+
+        $this->assertTrue($connection->beginTransaction());
+        $this->assertTrue($connection->commit());
+    }
+
+    public function test_rollback(): void
+    {
+        $connection = new PDOConnection(new SQLiteConnection(self::PATH));
+        $connection->connect();
+
+        $this->assertTrue($connection->beginTransaction());
+        $this->assertTrue($connection->rollback());
+    }
+
+    public function test_last_insert_id(): void
+    {
+        $connection = new PDOConnection(new SQLiteConnection(self::PATH));
+        $connection->connect();
+
+        $this->assertSame('0', $connection->lastInsertId());
+    }
+
+    public function test_prepare(): void
+    {
+        $connection = new PDOConnection(new SQLiteConnection(self::PATH));
+        $connection->connect();
+
+        $this->assertNotFalse($connection->prepare('select 1'));
+    }
+}