Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures #384

Merged
merged 4 commits into from
Jun 8, 2023
Merged

Fix test failures #384

merged 4 commits into from
Jun 8, 2023

Conversation

oraclown
Copy link
Collaborator

@oraclown oraclown commented Jun 8, 2023

  • Closes missing fuse account #383 by removing an unused fixture
  • Updates another test to expect a ValueError instead of one it wasn't throwing

@oraclown oraclown requested a review from akremstudy June 8, 2023 14:05
@codecov-commenter
Copy link

Codecov Report

Merging #384 (2bab691) into main (a732ced) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   90.80%   90.78%   -0.02%     
==========================================
  Files          21       21              
  Lines         598      586      -12     
==========================================
- Hits          543      532      -11     
+ Misses         55       54       -1     
Impacted Files Coverage Δ
tests/conftest.py 85.71% <ø> (-0.86%) ⬇️
tests/test_rpc_endpoint.py 100.00% <100.00%> (ø)

@akremstudy akremstudy merged commit 7f54de8 into main Jun 8, 2023
@akremstudy akremstudy deleted the rmv-fuse-test-fixture branch June 8, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing fuse account
3 participants